change: enable stream proxy only by default#4580
Merged
Merged
Conversation
Signed-off-by: spacewander <[email protected]>
spacewander
marked this pull request as ready for review
July 10, 2021 07:39
Contributor
|
It is confusing for using the configuration in stream-proxy to control the http-proxy. |
Member
Author
|
The HTTP proxy already at the top level of apisix. There can't be "the same level" unless we downgrade the level of HTTP proxy. |
tzssangglass
approved these changes
Jul 13, 2021
tzssangglass
approved these changes
Jul 14, 2021
nic-chen
approved these changes
Jul 14, 2021
starsz
approved these changes
Jul 14, 2021
|
so, You need to declare |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Signed-off-by: spacewander [email protected]
What this PR does / why we need it:
Pre-submission checklist: