feat: enable balancer phase for plugins#4549
Merged
Merged
Conversation
spacewander
marked this pull request as ready for review
July 7, 2021 02:38
Signed-off-by: spacewander <[email protected]>
Signed-off-by: spacewander <[email protected]>
tokers
approved these changes
Jul 7, 2021
Member
|
cc @dmsolr |
tzssangglass
approved these changes
Jul 7, 2021
Signed-off-by: spacewander <[email protected]>
starsz
reviewed
Jul 14, 2021
|
|
||
| end | ||
|
|
||
| local _, run = plugin_funcs("balancer") |
Contributor
There was a problem hiding this comment.
We will run balancer twice?
Line 312 and line 326 ?
Member
Author
There was a problem hiding this comment.
Fixed in the new commit
tao12345666333
approved these changes
Jul 14, 2021
Signed-off-by: spacewander <[email protected]>
starsz
approved these changes
Jul 14, 2021
| --- grep_error_log eval | ||
| qr/(run balancer phase with [\d.]+)/ | ||
| --- grep_error_log_out | ||
| run balancer phase with 127.0.0.2 |
Member
There was a problem hiding this comment.
I don't understand why there are two run balancer phases with ……
Member
Author
There was a problem hiding this comment.
The last one is for retry
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
8 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Signed-off-by: spacewander [email protected]
What this PR does / why we need it:
Pre-submission checklist: