feat(stream): add limit-conn#4515
Merged
Merged
Conversation
Signed-off-by: spacewander <[email protected]>
spacewander
marked this pull request as ready for review
July 1, 2021 12:19
https: //github.com/apache/pull/4515/checks?check_run_id=2962435093 Signed-off-by: spacewander <[email protected]>
Signed-off-by: spacewander <[email protected]>
Signed-off-by: spacewander <[email protected]>
tokers
reviewed
Jul 2, 2021
|
|
||
| **注：key 是可以被用户自定义的，只需要修改插件的一行代码即可完成。并没有在插件中放开是处于安全的考虑。** | ||
|
|
||
| : when used in the stream proxy, only `remote_addr` and `server_addr` can be used as `key`. And `rejected_code` is meaningless. |
Contributor
There was a problem hiding this comment.
What is the meaning of the leading colon symbol?
Signed-off-by: spacewander <[email protected]>
Signed-off-by: spacewander <[email protected]>
spacewander
marked this pull request as draft
July 2, 2021 05:26
spacewander
force-pushed
the
lcs
branch
4 times, most recently
from
July 2, 2021 08:48
31f8320 to
8d4a88a
Compare
Signed-off-by: spacewander <[email protected]>
spacewander
marked this pull request as ready for review
July 2, 2021 09:41
tzssangglass
approved these changes
Jul 7, 2021
tokers
approved these changes
Jul 8, 2021
Signed-off-by: spacewander <[email protected]>
Signed-off-by: spacewander <[email protected]>
tao12345666333
approved these changes
Jul 13, 2021
tao12345666333
left a comment
tao12345666333
left a comment
Member
There was a problem hiding this comment.
Approved.
Leave a comment, but it doesn’t affect.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Signed-off-by: spacewander [email protected]
What this PR does / why we need it:
Pre-submission checklist: