feat(stream): support stream subsystem discovery#4488
Closed
zhixiongdu027 wants to merge 5 commits into
Closed
Conversation
Signed-off-by: adugeek <[email protected]>
Contributor
|
@adugeek Please add some test cases to verify the changes are effective. |
spacewander
reviewed
Jun 27, 2021
| local discovery = require("apisix.discovery.init").discovery | ||
| if discovery and discovery.init_worker then | ||
| discovery.init_worker() | ||
| end |
Member
There was a problem hiding this comment.
You can add a test with the DNS discovery:
apisix/t/discovery/dns/sanity.t
Line 91 in 07bfe5b
You can setup it with
Line 33 in 07bfe5b
tokers
reviewed
Jul 2, 2021
| --- stream_response | ||
| hello world | ||
| --- no_error_log | ||
| [error] No newline at end of file |
Contributor
There was a problem hiding this comment.
Should add the EOS symbol. Please check your editor.
Contributor
|
@adugeek Please check out the CI status. |
Contributor
Author
|
@tokers sorry, busying in the past week. |
Signed-off-by: adugeek <[email protected]>
Yiyiyimu
reviewed
Jul 8, 2021
Member
|
@adugeek CI failed, please recheck |
added 3 commits
July 10, 2021 10:18
Signed-off-by: adugeek <[email protected]
Signed-off-by: adugeek <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Signed-off-by: adugeek [email protected]
What this PR does / why we need it:
resolve: #4469
int function init.lua:stream_init_worker() not call discovery.init_worker(),
so, we can't use discovery in stream subsystem.
by this pr, we can slove it
of course, the current and future discovery components need to ensure they can work in the stream subsystem
Pre-submission checklist: