Skip to content

feat(client-control): set client_max_body_size dynamically#4423

Merged
tokers merged 3 commits into
apache:masterfrom
spacewander:crcr
Jun 16, 2021
Merged

feat(client-control): set client_max_body_size dynamically#4423
tokers merged 3 commits into
apache:masterfrom
spacewander:crcr

Conversation

@spacewander

Copy link
Copy Markdown
Member

Signed-off-by: spacewander [email protected]

What this PR does / why we need it:

Pre-submission checklist:

  • Did you explain what problem does this PR solve? Or what new features have been added?
  • Have you added corresponding test cases?
  • Have you modified the corresponding document?
  • Is this PR backward compatible? If it is not backward compatible, please discuss on the mailing list first

@spacewander
spacewander marked this pull request as ready for review June 15, 2021 07:57
Comment thread conf/config-default.yaml Outdated
#cmd: ["ls", "-l"]

plugins: # plugin list (sorted by priority)
- client-control # priority: 22000

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Keep the comment with same indent?

@@ -0,0 +1,104 @@
---
title: ext-plugin-pre-req

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

bad title.

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@tokers
Updated.

@juzhiyuan juzhiyuan left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Logics are hard for me, only check the documentation :)

Comment thread docs/en/latest/plugins/client-control.md Outdated
Signed-off-by: spacewander <[email protected]>
Comment thread t/plugin/client-control.t Outdated
},
"plugins": {
"client-control": {
"max_body_size": 5

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It seems that the configuration doesn't match the title (0 means no limit).

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@tokers
Updated.

Signed-off-by: spacewander <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants