feat(mqtt-proxy): support domain#4391
Merged
Merged
Conversation
Fix apache#3964 Signed-off-by: spacewander <[email protected]>
spacewander
marked this pull request as ready for review
June 8, 2021 08:51
Yiyiyimu
reviewed
Jun 8, 2021
| | protocol_level | integer | 必须 | | | 协议级别，MQTT `3.1.*` 应为 `4` ，MQTT `5.0` 应是`5`。 | | ||
| | upstream.ip | string | 必须 | | | 将当前请求转发到的上游的 IP 地址 | | ||
| | upstream.host | string | 必须 | | | 将当前请求转发到的上游的 IP 地址或域名 | | ||
| | upstream.ip | string | 必须 | | | 推荐使用“host”代替。将当前请求转发到的上游的 IP 地址 | |
Member
There was a problem hiding this comment.
since we only need one of them, naming both of them 'required' might lead to misunderstanding
nic-chen
approved these changes
Jun 8, 2021
Signed-off-by: spacewander <[email protected]>
tokers
reviewed
Jun 9, 2021
tokers
approved these changes
Jun 9, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix #3964
Signed-off-by: spacewander [email protected]
What this PR does / why we need it:
Pre-submission checklist: