fix: ensure the plugin is always reloaded#4319
Merged
Merged
Conversation
Only trigger a reset from admin when the etcd's data is different from the one of admin. So there is no need to add check in node side. Fix apache#4314 Signed-off-by: spacewander <[email protected]>
spacewander
marked this pull request as ready for review
May 27, 2021 06:30
Signed-off-by: spacewander <[email protected]>
tokers
approved these changes
May 27, 2021
Signed-off-by: spacewander <[email protected]>
Signed-off-by: spacewander <[email protected]>
Signed-off-by: spacewander <[email protected]>
Firstsawyou
reviewed
May 27, 2021
dabue
approved these changes
May 31, 2021
dabue
left a comment
dabue
left a comment
Contributor
There was a problem hiding this comment.
LGTM, the logic of the new approach is clearer.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Only trigger a reset from admin when the etcd's data is different
from the one of admin. So there is no need to add check in node side.
Fix #4314
Signed-off-by: spacewander [email protected]
What this PR does / why we need it:
Pre-submission checklist: