Skip to content

feat: nacos discovery support namespace#4313

Merged
spacewander merged 3 commits into
apache:masterfrom
Demogorgon314:nacos_discovery_support_namespace
May 27, 2021
Merged

feat: nacos discovery support namespace#4313
spacewander merged 3 commits into
apache:masterfrom
Demogorgon314:nacos_discovery_support_namespace

Conversation

@Demogorgon314

Copy link
Copy Markdown
Member

What this PR does / why we need it:

#4306

Pre-submission checklist:

  • Did you explain what problem does this PR solve? Or what new features have been added?
  • Have you added corresponding test cases?
  • Have you modified the corresponding document?
  • Is this PR backward compatible? If it is not backward compatible, please discuss on the mailing list first

Comment thread t/discovery/nacos.t Outdated
Comment thread t/discovery/nacos.t Outdated
Comment thread apisix/discovery/nacos.lua Outdated
@spacewander

Copy link
Copy Markdown
Member

The CI is always pending on "wait nacos reg..."

@Demogorgon314

Demogorgon314 commented May 27, 2021

Copy link
Copy Markdown
Member Author

The CI is always pending on "wait nacos reg..."

I changed nacos-test-service Dockerfile , should be related to this @spacewander
api7/nacos-test-service#1

Comment thread apisix/schema_def.lua Outdated
Comment thread t/discovery/nacos.t
@Demogorgon314
Demogorgon314 force-pushed the nacos_discovery_support_namespace branch from 20d99da to 2a1fa6f Compare May 27, 2021 04:35
Comment thread docs/en/latest/discovery/nacos.md Outdated
Comment thread docs/en/latest/discovery/nacos.md Outdated
@spacewander
spacewander merged commit 0746f81 into apache:master May 27, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants