Skip to content

feat: patch tcp.sock.connect to use our DNS resolver#4114

Merged
spacewander merged 3 commits into
apache:masterfrom
spacewander:pcr
May 4, 2021
Merged

feat: patch tcp.sock.connect to use our DNS resolver#4114
spacewander merged 3 commits into
apache:masterfrom
spacewander:pcr

Conversation

@spacewander

Copy link
Copy Markdown
Member

Fix #3719

Signed-off-by: spacewander [email protected]

What this PR does / why we need it:

Pre-submission checklist:

  • Did you explain what problem does this PR solve? Or what new features have been added?
  • Have you added corresponding test cases?
  • Have you modified the corresponding document?
  • Is this PR backward compatible? If it is not backward compatible, please discuss on the mailing list first

@spacewander
spacewander force-pushed the pcr branch 2 times, most recently from 748cedf to b5e77ba Compare April 23, 2021 07:08
@spacewander
spacewander marked this pull request as ready for review April 23, 2021 08:15
Comment thread apisix/core/resolver.lua Outdated
Signed-off-by: spacewander <[email protected]>

@membphis membphis left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@spacewander
spacewander merged commit f914807 into apache:master May 4, 2021
@spacewander
spacewander deleted the pcr branch May 4, 2021 05:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

3 participants