Skip to content

feat(key-auth): allow customizing header#4013

Merged
spacewander merged 1 commit into
apache:masterfrom
spacewander:key-auth-hdr
Apr 9, 2021
Merged

feat(key-auth): allow customizing header#4013
spacewander merged 1 commit into
apache:masterfrom
spacewander:key-auth-hdr

Conversation

@spacewander

@spacewander spacewander commented Apr 9, 2021

Copy link
Copy Markdown
Member

Signed-off-by: spacewander [email protected]

What this PR does / why we need it:

Pre-submission checklist:

  • Did you explain what problem does this PR solve? Or what new features have been added?
  • Have you added corresponding test cases?
  • Have you modified the corresponding document?
  • Is this PR backward compatible? If it is not backward compatible, please discuss on the mailing list first

@spacewander
spacewander marked this pull request as ready for review April 9, 2021 05:33
Yiyiyimu
Yiyiyimu approved these changes Apr 9, 2021
View reviewed changes

@Yiyiyimu Yiyiyimu left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@spacewander
spacewander merged commit 89d8697 into apache:master Apr 9, 2021
@spacewander
spacewander deleted the key-auth-hdr branch April 9, 2021 10:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@tokers tokers tokers approved these changes
@Yiyiyimu Yiyiyimu Yiyiyimu approved these changes
@ShiningRush ShiningRush Awaiting requested review from ShiningRush
@membphis membphis Awaiting requested review from membphis

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@spacewander @tokers @Yiyiyimu