Skip to content

change(prometheus): don't expose metrics to internet#3994

Merged
spacewander merged 1 commit into
apache:masterfrom
spacewander:pro
Apr 7, 2021
Merged

change(prometheus): don't expose metrics to internet#3994
spacewander merged 1 commit into
apache:masterfrom
spacewander:pro

Conversation

@spacewander

Copy link
Copy Markdown
Member

Signed-off-by: spacewander [email protected]

What this PR does / why we need it:

Pre-submission checklist:

  • Did you explain what problem does this PR solve? Or what new features have been added?
  • Have you added corresponding test cases?
  • Have you modified the corresponding document?
  • Is this PR backward compatible? If it is not backward compatible, please discuss on the mailing list first

@spacewander
spacewander force-pushed the pro branch 2 times, most recently from 7e41b56 to 8fc0792 Compare April 6, 2021 11:15
@spacewander
spacewander marked this pull request as ready for review April 6, 2021 12:09
@spacewander
spacewander requested review from membphis and starsz April 6, 2021 12:10

@membphis membphis left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice way, LGTM

@starsz
starsz requested a review from nic-chen April 7, 2021 01:26
@spacewander
spacewander merged commit 6a986f4 into apache:master Apr 7, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants