change(zipkin): rearrange the child span#3877
Merged
Merged
Conversation
If you need to be compatible with the old one, you can set the span_version to 1. Fix apache#3827 Signed-off-by: spacewander <[email protected]>
spacewander
marked this pull request as ready for review
March 22, 2021 08:06
lilien1010
approved these changes
Mar 22, 2021
| local request_span = ctx.opentracing.request_span | ||
| ctx.opentracing.rewrite_span = request_span:start_child_span( | ||
| "apisix.rewrite", start_timestamp) | ||
| if conf.span_version == 1 then |
Member
There was a problem hiding this comment.
what about user pre-defined version const?
Signed-off-by: spacewander <[email protected]>
Firstsawyou
reviewed
Mar 23, 2021
| └── body_filter | ||
| ``` | ||
|
|
||
| 注意上述的 span 的名称跟同名的 Nginx phase 没有关系。 |
Contributor
There was a problem hiding this comment.
Suggested change
| 注意上述的 span 的名称跟同名的 Nginx phase 没有关系。 | |
| 注意：上述的 span 的名称跟同名的 Nginx phase 没有关系。 |
This should be better.
membphis
approved these changes
Mar 23, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
If you need to be compatible with the old one, you can set the
span_version to 1.
Fix #3827
Signed-off-by: spacewander [email protected]
What this PR does / why we need it:
Pre-submission checklist: