Skip to content

feat: load etcd configuration when apisix starts#3799

Merged
tokers merged 1 commit into
apache:masterfrom
spacewander:etcd_init
Mar 12, 2021
Merged

feat: load etcd configuration when apisix starts#3799
tokers merged 1 commit into
apache:masterfrom
spacewander:etcd_init

Conversation

@spacewander

@spacewander spacewander commented Mar 10, 2021

Copy link
Copy Markdown
Member

Fix #3370
Signed-off-by: spacewander [email protected]

What this PR does / why we need it:

Pre-submission checklist:

  • Did you explain what problem does this PR solve? Or what new features have been added?
  • Have you added corresponding test cases?
  • Have you modified the corresponding document?
  • Is this PR backward compatible? If it is not backward compatible, please discuss on the mailing list first

@spacewander spacewander changed the title WIP feat: load etcd configuration when apisix starts Mar 10, 2021
@spacewander
spacewander force-pushed the etcd_init branch 2 times, most recently from a625b48 to 9d55aa2 Compare March 10, 2021 10:29
@spacewander
spacewander marked this pull request as ready for review March 10, 2021 12:11
@spacewander
spacewander requested review from membphis and tokers March 10, 2021 12:12

@membphis membphis left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is an interesting PR, welcome @tokers to take a look

@tokers

tokers commented Mar 10, 2021

Copy link
Copy Markdown
Contributor

This is an interesting PR, welcome @tokers to take a look

OK.

@membphis
membphis requested review from Yiyiyimu and nic-chen March 11, 2021 01:23

@nic-chen nic-chen left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

need some time to read the code..

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

bug: http service should not be started before etcd data is pulled

4 participants