Skip to content

feat: let balancer support priority#3755

Merged
spacewander merged 1 commit into
apache:masterfrom
spacewander:pri
Mar 10, 2021
Merged

feat: let balancer support priority#3755
spacewander merged 1 commit into
apache:masterfrom
spacewander:pri

Conversation

@spacewander

Copy link
Copy Markdown
Member

Fix #1809
Signed-off-by: spacewander [email protected]

What this PR does / why we need it:

Pre-submission checklist:

  • Did you explain what problem does this PR solve? Or what new features have been added?
  • Have you added corresponding test cases?
  • Have you modified the corresponding document?
  • Is this PR backward compatible? If it is not backward compatible, please discuss on the mailing list first

@spacewander
spacewander marked this pull request as ready for review March 4, 2021 11:31
@spacewander
spacewander requested review from membphis and tokers March 4, 2021 11:48

@membphis membphis left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Comment thread t/admin/balancer.t
{host = "39.97.63.215", port = 80, weight = 1},
{host = "39.97.63.216", port = 81, weight = 1},
{host = "39.97.63.217", port = 82, weight = 1},
{host = "39.97.63.215", port = 80, weight = 1, priority = 0},

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the default value of priority is 0, so we can keep it not change, all right?

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes.

@spacewander
spacewander merged commit 8dcbe4e into apache:master Mar 10, 2021
@spacewander
spacewander deleted the pri branch March 10, 2021 06:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

request help: Health Checks can support Backup server?

3 participants