Skip to content

fix: script does not work when the route is bound to a service.#3678

Merged
membphis merged 4 commits into
apache:masterfrom
tzssangglass:IssueNo3663
Feb 26, 2021
Merged

fix: script does not work when the route is bound to a service.#3678
membphis merged 4 commits into
apache:masterfrom
tzssangglass:IssueNo3663

Conversation

@tzssangglass

Copy link
Copy Markdown
Member

What this PR does / why we need it:

fix: #3663

Pre-submission checklist:

  • Did you explain what problem does this PR solve? Or what new features have been added?
  • Have you added corresponding test cases?
  • Have you modified the corresponding document?
  • Is this PR backward compatible? If it is not backward compatible, please discuss on the mailing list first

@tzssangglass tzssangglass changed the title bugfix: fix script does not work when route binding service bugfix: fix script does not work when route binding service. Feb 25, 2021
@tzssangglass tzssangglass changed the title bugfix: fix script does not work when route binding service. bugfix: fix script does not work when the route is bound to a service. Feb 25, 2021
@tzssangglass

Copy link
Copy Markdown
Member Author

@spacewander @membphis CI is ok, but I don't koow why PR title is solecistic

@Firstsawyou

Copy link
Copy Markdown
Contributor

Your PR title needs to look like this: fix: script does not work when the route is bound to a service

@spacewander spacewander changed the title bugfix: fix script does not work when the route is bound to a service. fix: script does not work when the route is bound to a service. Feb 26, 2021
Comment thread t/admin/script.t Outdated
Comment thread t/admin/script.t
@membphis
membphis merged commit a6fbcce into apache:master Feb 26, 2021
@tzssangglass
tzssangglass deleted the IssueNo3663 branch February 26, 2021 14:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

bug: script does not work

5 participants