chore: capitalize the constant #3672
Merged
Merged
Conversation
spacewander
marked this pull request as ready for review
February 25, 2021 11:15
spacewander
changed the title
See apache#3629 (comment) Signed-off-by: spacewander <[email protected]>
tokers
reviewed
Feb 25, 2021
| local new_nodes, err = dis.nodes(up_conf.service_name) | ||
| if not new_nodes then | ||
| return http_code_upstream_unavailable, "no valid upstream node: " .. (err or "nil") | ||
| return HTTP_CODE_UPSTREAM_UNAVAILABLE, "no valid upstream node: " .. (err or "nil") |
Contributor
There was a problem hiding this comment.
Why not use ngx.HTTP_SERVICE_UNAVAILABLE
Member
Author
There was a problem hiding this comment.
I think it is because the status code for this has been changed from 500 to 503. So the original contributor use a variable instead.
spacewander
changed the title
tokers
approved these changes
Feb 26, 2021
membphis
approved these changes
Feb 27, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See #3629 (comment)
Signed-off-by: spacewander [email protected]
What this PR does / why we need it:
Pre-submission checklist: