fix(chash): ensure retry can try every node#3651
Merged
Merged
Conversation
Previously the default number of retry is equal to the number of node, but the same node will be tried again according to its weight. Also ensure the same picker will be used in the whole request, especially during the retry. Signed-off-by: spacewander <[email protected]>
spacewander
force-pushed
the
chash_retry
branch
from
February 24, 2021 03:06
9c58541 to
fc92fce
Compare
spacewander
marked this pull request as ready for review
February 24, 2021 05:00
tokers
approved these changes
Feb 24, 2021
membphis
approved these changes
Feb 27, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Previously the default number of retry is equal to the number of node,
but the same node will be tried again according to its weight.
Also ensure the same picker will be used in the whole request,
especially during the retry.
Signed-off-by: spacewander [email protected]
What this PR does / why we need it:
Pre-submission checklist: