feat: add dns discovery#3629
Merged
Merged
Conversation
spacewander
force-pushed
the
dns_discovery
branch
5 times, most recently
from
February 22, 2021 11:32
1b6f00d to
b3c6ecf
Compare
Fix apache#3517 Signed-off-by: spacewander <[email protected]>
spacewander
force-pushed
the
dns_discovery
branch
from
February 22, 2021 12:09
b3c6ecf to
197f650
Compare
spacewander
marked this pull request as ready for review
February 22, 2021 12:51
tokers
approved these changes
Feb 23, 2021
membphis
approved these changes
Feb 25, 2021
membphis
left a comment
membphis
left a comment
Member
There was a problem hiding this comment.
LGTM, except minor style things
|
|
||
| local new_nodes, err = dis.nodes(up_conf.service_name) | ||
| if not new_nodes then | ||
| return http_code_upstream_unavailable, "no valid upstream node: " .. (err or "nil") |
Member
There was a problem hiding this comment.
http_code_upstream_unavailable:
For static variables, use capital letters
Member
Author
Member
Author
There was a problem hiding this comment.
I changed my idea and followed your suggestion.
spacewander
added a commit
to spacewander/incubator-apisix
that referenced
this pull request
Feb 25, 2021
See apache#3629 (comment) Signed-off-by: spacewander <[email protected]>
4 tasks
spacewander
added a commit
to spacewander/incubator-apisix
that referenced
this pull request
Feb 25, 2021
See apache#3629 (comment) Signed-off-by: spacewander <[email protected]>
membphis
pushed a commit
that referenced
this pull request
Feb 27, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix #3517
Signed-off-by: spacewander [email protected]
What this PR does / why we need it:
Pre-submission checklist: