Skip to content

feat: add consul kv discovery module#3615

Merged
spacewander merged 11 commits into
apache:masterfrom
yongboy:consul_kv
Feb 23, 2021
Merged

feat: add consul kv discovery module#3615
spacewander merged 11 commits into
apache:masterfrom
yongboy:consul_kv

Conversation

@yongboy

@yongboy yongboy commented Feb 20, 2021

Copy link
Copy Markdown
Contributor

What this PR does / why we need it:

As I mentioned previously in the mail-list, my team submit the consul_kv discovery module now.

More introductions here:
https://github.com/yongboy/apisix/blob/consul_kv/doc/discovery/consul_kv.md

Pre-submission checklist:

  • Did you explain what problem does this PR solve? Or what new features have been added?
  • Have you added corresponding test cases?
  • Have you modified the corresponding document?
  • Is this PR backward compatible? If it is not backward compatible, please discuss on the mailing list first

@tokers

tokers commented Feb 20, 2021

Copy link
Copy Markdown
Contributor

@yongboy The linters failed, you may try to run make lint on your side and fix all lint errors.

Comment thread apisix/discovery/consul_kv.lua Outdated
Comment thread apisix/discovery/consul_kv.lua Outdated
Comment thread apisix/discovery/consul_kv.lua Outdated
Comment thread apisix/discovery/consul_kv.lua Outdated
Comment thread apisix/discovery/consul_kv.lua Outdated
Comment thread apisix/discovery/consul_kv.lua Outdated
Comment thread apisix/discovery/consul_kv.lua Outdated
Comment thread doc/discovery/consul_kv.md Outdated
Comment thread doc/discovery/consul_kv.md Outdated
Comment thread apisix/discovery/consul_kv.lua Outdated
Comment thread apisix/discovery/consul_kv.lua
Comment thread apisix/discovery/consul_kv.lua Outdated
Comment thread apisix/discovery/consul_kv.lua Outdated
Comment thread doc/discovery.md Outdated
Comment thread doc/discovery/consul_kv.md Outdated
Comment thread doc/discovery/consul_kv.md Outdated
Comment thread doc/discovery/consul_kv.md Outdated
Comment thread doc/discovery/consul_kv.md Outdated
Comment thread apisix/discovery/consul_kv.lua Outdated
Comment thread apisix/discovery/consul_kv.lua Outdated
Comment thread doc/discovery/consul_kv.md
@spacewander
spacewander merged commit 8b7d937 into apache:master Feb 23, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants