change: default to cache DNS record according to the TTL#3530
Merged
Conversation
spacewander
force-pushed
the
dns_cache
branch
from
February 5, 2021 09:28
c017492 to
bc06f82
Compare
spacewander
marked this pull request as ready for review
February 5, 2021 10:15
Since lua-resty-dns-client provides an internal cache, we don't need to cache it twice. Signed-off-by: spacewander <[email protected]>
spacewander
force-pushed
the
dns_cache
branch
from
February 5, 2021 11:06
bc06f82 to
769f045
Compare
membphis
approved these changes
Feb 5, 2021
| end | ||
|
|
||
| if yaml_conf.apisix.dns_resolver_valid then | ||
| if tonumber(yaml_conf.apisix.dns_resolver_valid) == nil then |
Member
There was a problem hiding this comment.
Can we use JSON Schema to check configuration values?
Contributor
There was a problem hiding this comment.
Seems that the whole config.yaml doesn't have the json schema.
Member
There was a problem hiding this comment.
I think it is time to do it in this way now
Contributor
There was a problem hiding this comment.
It's more proper to do it in another PR.
lilien1010
approved these changes
Feb 10, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Since lua-resty-dns-client provides an internal cache, we don't need to
cache it twice.
Signed-off-by: spacewander [email protected]
What this PR does / why we need it:
Pre-submission checklist: