Skip to content

feat: support DNS AAAA record#3484

Merged
spacewander merged 3 commits into
apache:masterfrom
spacewander:codns
Feb 5, 2021
Merged

feat: support DNS AAAA record#3484
spacewander merged 3 commits into
apache:masterfrom
spacewander:codns

Conversation

@spacewander

Copy link
Copy Markdown
Member

Fix #2495
Signed-off-by: spacewander [email protected]

What this PR does / why we need it:

Pre-submission checklist:

  • Did you explain what problem does this PR solve? Or what new features have been added?
  • Have you added corresponding test cases?
  • Have you modified the corresponding document?
  • Is this PR backward compatible? If it is not backward compatible, please discuss on the mailing list first

@spacewander
spacewander marked this pull request as ready for review February 2, 2021 13:41
@spacewander
spacewander requested a review from membphis February 2, 2021 13:41

@membphis membphis left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Comment thread utils/set-dns.sh Outdated
mkdir -p build-cache

if [ ! -f "build-cache/coredns_1_8_1" ]; then
wget https://github.com/coredns/coredns/releases/download/v1.8.1/coredns_1.8.1_linux_amd64.tgz

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

bad indentation

Signed-off-by: spacewander <[email protected]>
@spacewander
spacewander force-pushed the codns branch 6 times, most recently from a158665 to 0f147ac Compare February 4, 2021 15:34
Signed-off-by: spacewander <[email protected]>
@spacewander
spacewander merged commit e1dbe2c into apache:master Feb 5, 2021
@spacewander
spacewander deleted the codns branch February 5, 2021 01:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

request help: dns parsing for ipv6

3 participants