feat: add control API#3048
Merged
Merged
Conversation
Signed-off-by: spacewander <[email protected]>
spacewander
marked this pull request as ready for review
December 15, 2020 04:13
jbampton
reviewed
Dec 15, 2020
Co-authored-by: John Bampton <[email protected]>
Co-authored-by: John Bampton <[email protected]>
jbampton
reviewed
Dec 15, 2020
| port: 9090 | ||
| ``` | ||
|
|
||
| Note that the control API server should not be configured to listen the public traffic! |
Member
There was a problem hiding this comment.
Suggested change
| Note that the control API server should not be configured to listen the public traffic! | |
| Note that the control API server should not be configured to listen to public traffic! |
| ## Control API Added via plugin | ||
|
|
||
| Plugin can add its control API when it is enabled. | ||
| If a plugin adds such control API, please refer to each plugin's documentation for those APIs. |
Member
There was a problem hiding this comment.
Suggested change
| If a plugin adds such control API, please refer to each plugin's documentation for those APIs. | |
| If a plugin adds such a control API, please refer to each plugin's documentation for those APIs. |
membphis
requested changes
Dec 15, 2020
| -- /v1/schema | ||
| { | ||
| methods = {"GET"}, | ||
| uri = "/schema", |
Member
There was a problem hiding this comment.
use uris is better, we'll remove uri later
Signed-off-by: spacewander <[email protected]>
Member
Author
Signed-off-by: spacewander <[email protected]>
tokers
reviewed
Dec 18, 2020
|
|
||
| ## Control API Added via plugin | ||
|
|
||
| Plugin can add its control API when it is enabled. |
Contributor
There was a problem hiding this comment.
Shall we add the control API example in plugin-develop.md?
Member
Author
There was a problem hiding this comment.
Yes, but we can do it later. It seems the plugin-develop.md is outdated and need to be rewritten.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Signed-off-by: spacewander [email protected]
What this PR does / why we need it:
Pre-submission checklist: