feat: support enable/disable route#2943
Conversation
|
Thanks for you pr :), just wait for others preview. |
|
nice PR |
membphis
left a comment
There was a problem hiding this comment.
please fix other similar points
|
solve above |
|
describe a strange phenomenon, I was using until I debugged at when run test, the after find this exception, something change, run the test case is back to normal, and cannot be reproduced. >_<||| |
|
is it necessary to add a case: |
If this magical event happened next, you may cc |
test case 1 ~ 4 is testing for uri match, the order is test case 5 ~ 8 is testing for host + uri match, the order is same as above. I think combining these four steps into one test case would have the same effect. |
membphis
left a comment
There was a problem hiding this comment.
LGTM, except minor style things
|
got it
Thanks,
Ming Wen
Twitter: _WenMing
罗泽轩 <[email protected]> 于2020年12月5日周六 下午9:25写道:
… ***@***.**** commented on this pull request.
------------------------------
In doc/zh-cn/admin-api.md
<#2943 (comment)>:
> @@ -76,6 +76,7 @@
|filter_func|可选|匹配规则|用户自定义的过滤函数。可以使用它来实现特殊场景的匹配要求实现。该函数默认接受一个名为 vars 的输入参数,可以用它来获取 Nginx 变量。|function(vars) return vars["arg_name"] == "json" end|
|labels |可选 |匹配规则|标识附加属性的键值对|{"version":"v2","build":"16","env":"production"}|
|enable_websocket|可选 |辅助| 是否启用 `websocket`(boolean), 缺省 `false`.||
+|status |可选 |辅助| 是否启用此路由, 缺省 `1`。|`1` 表示启用,`0` 表示禁用|
|create_time|可选|辅助|单位为秒的 epoch 时间戳,如果不指定则自动创建|1602883670|
@moonming <https://github.com/moonming> @nic-chen
<https://github.com/nic-chen>
The last item 1602883670 is an example, not the default value.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#2943 (comment)>, or
unsubscribe
<https://github.com/notifications/unsubscribe-auth/AGJZBK5QQEEOV5BXKKFHUA3STIYDBANCNFSM4ULQ4ZMA>
.
|
|
thanks to the people at code review, and thanks for the guidance! |
Signed-off-by: spacewander <[email protected]>
Signed-off-by: spacewander <[email protected]>
fix #2737
What this PR does / why we need it:
Pre-submission checklist: