feat: share etcd client#2932
Merged
Merged
Conversation
Member
Author
|
Required: api7/lua-resty-etcd#100 |
spacewander
force-pushed
the
share_cli
branch
3 times, most recently
from
December 9, 2020 04:20
1f3e4ae to
3db9912
Compare
Signed-off-by: spacewander <[email protected]>
spacewander
force-pushed
the
share_cli
branch
from
December 9, 2020 07:39
3db9912 to
fb66f19
Compare
spacewander
marked this pull request as ready for review
December 9, 2020 08:04
membphis
reviewed
Dec 9, 2020
membphis
left a comment
membphis
left a comment
Member
There was a problem hiding this comment.
we can merge this PR after release version 2.2.
Because we updated the way to connect to etcd, it takes more time to confirm if it works
Signed-off-by: spacewander <[email protected]>
tokers
approved these changes
Dec 15, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Need to change lua-resty-etcd for this feature
For #2899
What this PR does / why we need it:
Pre-submission checklist: