Skip to content

feat: support ENV variable in configuration#2743

Merged
spacewander merged 2 commits into
apache:masterfrom
spacewander:type
Nov 14, 2020
Merged

feat: support ENV variable in configuration#2743
spacewander merged 2 commits into
apache:masterfrom
spacewander:type

Conversation

@spacewander

@spacewander spacewander commented Nov 13, 2020

Copy link
Copy Markdown
Member

Close #2675.

What this PR does / why we need it:

Pre-submission checklist:

  • Did you explain what problem does this PR solve? Or what new features have been added?
  • Have you added corresponding test cases?
  • Have you modified the corresponding document?
  • Is this PR backward compatible?

@nic-chen

nic-chen commented Nov 13, 2020

Copy link
Copy Markdown
Member

nice feature.

nic-chen
nic-chen approved these changes Nov 13, 2020
View reviewed changes

@nic-chen nic-chen left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@agile6v
agile6v self-requested a review November 14, 2020 10:35
agile6v
agile6v approved these changes Nov 14, 2020
View reviewed changes
Comment thread .travis/apisix_cli_test.sh Outdated

echo "passed: change default env"

# support environment varialbes

@agile6v agile6v Nov 14, 2020

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

varialbes => variables

@agile6v agile6v Nov 14, 2020 •
edited
Loading

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There are same typos below.

@spacewander spacewander Nov 14, 2020

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@agile6v
Typo fixed.

@spacewander
spacewander merged commit 6b52811 into apache:master Nov 14, 2020
@moonming moonming added this to the 2.1 milestone Nov 21, 2020
@spacewander spacewander mentioned this pull request Nov 21, 2020
Closed
@moonming moonming mentioned this pull request Nov 29, 2020
Merged
4 tasks
@diaosj diaosj mentioned this pull request Dec 10, 2020
Closed
@Baoyuantop Baoyuantop mentioned this pull request Jan 26, 2026
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@agile6v agile6v agile6v approved these changes
@nic-chen nic-chen nic-chen approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

2.1

Development

Successfully merging this pull request may close these issues.

feat: support ENV variable in conf/config.yaml

4 participants

@spacewander @nic-chen @agile6v @moonming