Skip to content

docs: add create/update_time fields#2712

Merged
juzhiyuan merged 1 commit into
apache:masterfrom
spacewander:cud
Nov 12, 2020
Merged

docs: add create/update_time fields#2712
juzhiyuan merged 1 commit into
apache:masterfrom
spacewander:cud

Conversation

@spacewander

Copy link
Copy Markdown
Member

Close #2654

What this PR does / why we need it:

Pre-submission checklist:

  • Did you explain what problem does this PR solve? Or what new features have been added?
  • Have you added corresponding test cases?
  • Have you modified the corresponding document?
  • Is this PR backward compatible?

@spacewander
spacewander requested a review from membphis November 12, 2020 01:42

@juzhiyuan juzhiyuan left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Comment thread doc/admin-api.md
|labels|False |Match Rules|Key/value pairs to specify attributes|{"version":"v2","build":"16","env":"production"}|
|labels|optional |Key/value pairs to specify attributes|{"version":"v2","build":"16","env":"production"}|
|create_time|optional| epoch timestamp in second, like `1602883670`|
|update_time|optional| epoch timestamp in second, like `1602883670`|

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

image

We may format all docs to have a uniform style in the future.

Comment thread doc/zh-cn/admin-api.md
|pass_host |可选|枚举|`pass` 透传客户端请求的 host, `node` 不透传客户端请求的 host, 使用 upstream node 配置的 host, `rewrite` 使用 `upstream_host` 配置的值重写 host 。||
|upstream_host |可选|辅助|只在 `pass_host` 配置为 `rewrite` 时有效。||
|labels |可选 |匹配规则|标识附加属性的键值对|{"version":"v2","build":"16","env":"production"}|
|create_time|可选|辅助|单位为秒的 epoch 时间戳|1602883670|

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we translate the epoch word?

image

@juzhiyuan
juzhiyuan merged commit 2f8762c into apache:master Nov 12, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

feat: there is no "createtime" when creating a consumer by adminAPI, which causes dashboard to display wrong "Update Time"

3 participants