fix(etcd): handle etcd compaction#2687
Merged
Merged
Conversation
Contributor
|
We can make a test case for the situation. |
Member
Author
|
@ShiningRush |
Contributor
|
it should reproduce by follow steps:
I haven't actually tried it yet, but I guess it should be able to reproduce stably |
Member
Author
|
@ShiningRush |
membphis
reviewed
Nov 11, 2020
|
|
||
| local compact_revision = v3res.result.compact_revision | ||
| if compact_revision and tonumber(compact_revision) > 0 then | ||
| -- When the revisions are compacted, there might be compacted changes |
Member
There was a problem hiding this comment.
add a todo comment, missing test cases, will add later
spacewander
force-pushed
the
etcd_compact_2680
branch
from
November 11, 2020 03:41
44a631e to
d1f4030
Compare
moonming
approved these changes
Nov 11, 2020
membphis
approved these changes
Nov 15, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Close #2680.
What this PR does / why we need it:
Pre-submission checklist: