fix(log-rotate): avoid creating multiple timers#2596
Merged
Conversation
Member
Author
|
This PR should be draft but I hit the wrong button by accident. |
spacewander
changed the title
juzhiyuan
marked this pull request as draft
November 2, 2020 06:04
spacewander
force-pushed
the
timer_out
branch
from
November 2, 2020 06:52
d252dc2 to
4b4b399
Compare
spacewander
force-pushed
the
timer_out
branch
from
November 3, 2020 07:20
4b4b399 to
dd74007
Compare
spacewander
changed the title
spacewander
marked this pull request as ready for review
November 3, 2020 08:25
Firstsawyou
reviewed
Nov 5, 2020
Firstsawyou
reviewed
Nov 5, 2020
membphis
reviewed
Nov 6, 2020
|
|
||
|
|
||
| function _M.init_worker() | ||
| -- currently only log-rotate needs the timer |
Member
There was a problem hiding this comment.
only for plugin log-rotate, the current way is enough.
but I think this library can be used for different plugins, it is basic library.
so I think we should remove https://github.com/apache/apisix/pull/2596/files#diff-6ff817ed7efbdfcf2da85cb1a68a48aa2ef9e18422b80b2f255fc41032ee773eR58-R60
dabue
approved these changes
Nov 8, 2020
membphis
approved these changes
Nov 8, 2020
dabue
approved these changes
Nov 8, 2020
dabue
left a comment
dabue
left a comment
Contributor
There was a problem hiding this comment.
I've used the 'apisix/timers' in my local plug-in, it worked well.
nic-chen
reviewed
Nov 8, 2020
| local timer, err = core.timer.new("background", background_timer, {check_interval = 0.5}) | ||
| if not timer then | ||
| core.log.error("failed to create background timer: ", err) | ||
| else |
Member
There was a problem hiding this comment.
we could return here，and remove 'else'
|
|
||
| local th, err = thread_spawn(timer) | ||
| if not th then | ||
| core.log.error("failed to spawn thread for timer [", name, "]: ", err) |
Member
There was a problem hiding this comment.
Should we use 'continue' here,since it's empty?
nic-chen
approved these changes
Nov 9, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
Pre-submission checklist: