feat: implement error-log-logger plug-in#2592
Merged
Merged
Conversation
membphis
changed the title
error-log-logger plug-in
membphis
requested changes
Nov 1, 2020
|
|
||
| if not sock then | ||
| err_msg = "failed to init the socket " .. soc_err | ||
| return res, err_msg |
Member
There was a problem hiding this comment.
style: return false, "failed to init the socket " .. soc_err, it is simpler
| if not ok then | ||
| err_msg = "failed to connect the TCP server: host[" .. config.host | ||
| .. "] port[" .. tostring(config.port) .. "] err: " .. err | ||
| return res, err_msg |
|
|
||
|
|
||
| local function send_to_server(data) | ||
| local res = false |
Member
There was a problem hiding this comment.
it seems useless, can we delete it?
| sock:close() | ||
| err_msg = "failed to send data to TCP server: host[" .. config.host | ||
| .. "] port[" .. tostring(config.port) .. "] err: " .. err | ||
| return res, err_msg |
|
|
||
|
|
||
| local function process() | ||
| if not loaded_flag then |
|
|
||
| local function process() | ||
| if not loaded_flag then | ||
| local code, body = plugin_metadata.get(plugin_name) |
Member
There was a problem hiding this comment.
this way is wrong, please take a look at: https://github.com/apache/apisix/blob/master/apisix/plugins/http-logger.lua#L166
|
|
||
| local log_buffer = buffers[id] | ||
| if log_buffer then | ||
| for i = 1, #entries do |
Member
There was a problem hiding this comment.
for i,v in ipairs(table_name) do this style is better for this case
| end | ||
|
|
||
| buffers[id] = log_buffer | ||
| for i = 1, #entries do |
Firstsawyou
reviewed
Nov 6, 2020
Comment on lines
+67
to
+68
| local config = { | ||
| } |
Contributor
There was a problem hiding this comment.
I think this local _M = {} format will look better, what do you think?
dabue
changed the title
error-log-logger plug-inerror-log-logger plug-in
dabue
changed the title
error-log-logger plug-inerror-log-logger plug-in
dabue
changed the title
error-log-logger plug-inerror-log-logger plug-in
Contributor
Author
|
@membphis please review. |
Member
Contributor
Author
dabue
force-pushed
the
error_log_plugin
branch
from
November 9, 2020 05:56
5360ec3 to
7285c3a
Compare
Contributor
Author
Member
membphis
reviewed
Nov 18, 2020
|
|
||
| ```yaml | ||
| plugins: # plugin list | ||
| - error-log-logger |
Member
There was a problem hiding this comment.
plugins: # plugin list
... ...
- request-id
- hmac-auth
- api-breaker
- error-log-logger # enable plugin `error-log-logger`
Member
spacewander
requested changes
Nov 19, 2020
| timeout = {type = "integer", minimum = 1, default = 3}, | ||
| keepalive = {type = "integer", minimum = 1, default = 30}, | ||
| name = {type = "string", default = plugin_name}, | ||
| level = {type = "string", default = "WARN"}, |
Member
There was a problem hiding this comment.
Need to validate with enum, like this: enum = {"GET", "POST", "PUT", "DELETE", "PATCH",
dabue
force-pushed
the
error_log_plugin
branch
from
November 28, 2020 10:08
80c2b13 to
028a454
Compare
Contributor
Author
|
@membphis @spacewander please review again, thx. |
spacewander
requested changes
Nov 28, 2020
| end | ||
|
|
||
| if config.tls then | ||
| ok, err = sock:sslhandshake(true, config.tls_options, false) |
Member
There was a problem hiding this comment.
The name tls_options is bad, in fact it isn't related with any options. Would be better to use tls_sni or tls_server_name.
dabue
force-pushed
the
error_log_plugin
branch
from
November 28, 2020 13:38
d1e2d4d to
0cad3ab
Compare
Member
|
@dabue you need to rebase your branch |
dabue
force-pushed
the
error_log_plugin
branch
from
November 29, 2020 02:07
0cad3ab to
6eaba11
Compare
Contributor
Author
|
@membphis @spacewander please review again, thx. |
spacewander
approved these changes
Nov 30, 2020
Member
|
@dabue many thx for your nice job |
5 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
add a plugin to collect error log and report to remote TCP server .
fix #2410
you can set the plugin's config in config-default.yaml, likes below:
plugins: # plugin list
and update it links below:
step 1: update the attributes of the plugin
curl http://127.0.0.1:9080//apisix/admin/plugin_metadata/error-log-logger -H 'X-API-KEY: edd1c9f034335f136f87ad84b625c8f1' -X PUT -d '
{
"host": "127.0.0.1",
"port": 1999,
"inactive_timeout": 1
}'