Skip to content

feature: add managed fields in json schema for resources, such as create_time and update_time#2444

Merged
nic-chen merged 3 commits into
apache:masterfrom
nic-chen:manage-fields
Oct 17, 2020
Merged

feature: add managed fields in json schema for resources, such as create_time and update_time#2444
nic-chen merged 3 commits into
apache:masterfrom
nic-chen:manage-fields

Conversation

@nic-chen

@nic-chen nic-chen commented Oct 17, 2020

Copy link
Copy Markdown
Member

What this PR does / why we need it:

add managed fields in json schema for resources, such as create_time and update_time

Pre-submission checklist:

  • Did you explain what problem does this PR solve? Or what new features have been added?
  • Have you added corresponding test cases?
  • Have you modified the corresponding document?
  • Is this PR backward compatible?

relate to #2433

@nic-chen nic-chen added this to the 2.0 milestone Oct 17, 2020
@nic-chen

Copy link
Copy Markdown
Member Author

add to milestone 2.0 because need these fields to work with new manager api #2444

@nic-chen
nic-chen requested review from membphis and moonming October 17, 2020 01:06
Comment thread t/admin/consumers.t
Comment thread t/admin/routes.t

@membphis membphis left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice PR ^_^

@membphis

Copy link
Copy Markdown
Member

@nic-chen I think you'd better add a link to the question in this PR. The community needs to know which issue is solved.

@nic-chen

Copy link
Copy Markdown
Member Author

@nic-chen I think you'd better add a link to the question in this PR. The community needs to know which issue is solved.

sure.I have modified the summary。

@nic-chen
nic-chen merged commit a92331c into apache:master Oct 17, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants