Skip to content

feat: use interceptors to protect plugin's route#2416

Merged
spacewander merged 4 commits into
apache:masterfrom
spacewander:interceptors
Oct 17, 2020
Merged

feat: use interceptors to protect plugin's route#2416
spacewander merged 4 commits into
apache:masterfrom
spacewander:interceptors

Conversation

@spacewander

Copy link
Copy Markdown
Member

What this PR does / why we need it:

Pre-submission checklist:

  • Did you explain what problem does this PR solve? Or what new features have been added?
  • Have you added corresponding test cases?
  • Have you modified the corresponding document?
  • Is this PR backward compatible?

TODO: add doc

Comment thread t/admin/plugin-metadata.t Outdated

@juzhiyuan juzhiyuan left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM from codes style

@membphis membphis left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Love this PR. Good design and implementation.

@spacewander
spacewander merged commit 6a543a9 into apache:master Oct 17, 2020
@moonming moonming added this to the 2.0 milestone Oct 19, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants