Skip to content

feat: add referer-restriction plugin#2352

Merged
membphis merged 3 commits into
apache:masterfrom
spacewander:xx
Oct 6, 2020
Merged

feat: add referer-restriction plugin#2352
membphis merged 3 commits into
apache:masterfrom
spacewander:xx

Conversation

@spacewander

@spacewander spacewander commented Oct 4, 2020

Copy link
Copy Markdown
Member

What this PR does / why we need it:

Pre-submission checklist:

  • Did you explain what problem does this PR solve? Or what new features have been added?
  • Have you added corresponding test cases?
  • Have you modified the corresponding document?
  • Is this PR backward compatible?

Comment thread apisix/plugins/referer-restriction.lua Outdated
local schema = {
type = "object",
properties = {
optional = {

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

may need a more meaningful name

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It’s still a bit confused, maybe we could use ʻallow_no_referer` or something. just a suggestion

Comment thread t/plugin/referer-restriction.t
@spacewander

Copy link
Copy Markdown
Member Author

@membphis
Done

@membphis
membphis merged commit 5b97223 into apache:master Oct 6, 2020
@membphis

membphis commented Oct 6, 2020

Copy link
Copy Markdown
Member

@spacewander merged, many thx

@moonming moonming added this to the 2.0 milestone Oct 19, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants