Skip to content

feat(http-logger): support to concat multiple log with separator.#2286

Merged
membphis merged 9 commits into
apache:masterfrom
membphis:http-logger-sep
Sep 24, 2020
Merged

feat(http-logger): support to concat multiple log with separator.#2286
membphis merged 9 commits into
apache:masterfrom
membphis:http-logger-sep

Conversation

@membphis

@membphis membphis commented Sep 23, 2020 •
edited
Loading

Copy link
Copy Markdown
Member

What this PR does / why we need it:

as title.

support to report log in this way:

curl http://****/log -d '
{xxxxxxxxxxxxx}
{yyyyyyyyyyyyy}
'

the request logs is concat by '\n' way.

Pre-submission checklist:

  • Did you explain what problem does this PR solve? Or what new features have been added?
  • Have you added corresponding test cases?
  • Have you modified the corresponding document?
  • Is this PR backward compatible?

@membphis
membphis marked this pull request as ready for review September 23, 2020 15:02
@membphis

membphis commented Sep 23, 2020

Copy link
Copy Markdown
Member Author

@gxthrj please take a look at this PR

@membphis
membphis requested a review from nic-chen September 23, 2020 22:29
@nic-chen

nic-chen commented Sep 24, 2020

Copy link
Copy Markdown
Member

I have a doubt, why not use a array json, but concat by '\n' ?

@nic-chen

nic-chen commented Sep 24, 2020

Copy link
Copy Markdown
Member

I have a doubt, why not use a array json, but concat by '\n' ?

ignore that, I see it supports two ways..

nic-chen
nic-chen reviewed Sep 24, 2020
View reviewed changes
Comment thread apisix/plugins/http-logger.lua
@membphis
membphis merged commit 3f9685f into apache:master Sep 24, 2020
@membphis
membphis deleted the http-logger-sep branch September 24, 2020 02:58
@guliuliu1 guliuliu1 mentioned this pull request Jun 18, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@gxthrj gxthrj gxthrj approved these changes
@nic-chen nic-chen nic-chen approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@membphis @nic-chen @gxthrj