fix: move conf/cert to t/certs and disable ssl by default#2112
Merged
Conversation
Member
|
@Yiyiyimu please fix the issue of CI |
Member
Author
Signed-off-by: yiyiyimu <[email protected]>
Signed-off-by: yiyiyimu <[email protected]>
Signed-off-by: yiyiyimu <[email protected]>
Signed-off-by: yiyiyimu <[email protected]>
Signed-off-by: yiyiyimu <[email protected]>
Signed-off-by: yiyiyimu <[email protected]>
…le_ssl' Signed-off-by: yiyiyimu <[email protected]>
Signed-off-by: yiyiyimu <[email protected]>
Signed-off-by: yiyiyimu <[email protected]>
Signed-off-by: yiyiyimu <[email protected]>
Signed-off-by: yiyiyimu <[email protected]>
Signed-off-by: yiyiyimu <[email protected]>
Signed-off-by: yiyiyimu <[email protected]>
Signed-off-by: yiyiyimu <[email protected]>
membphis
changed the title
conf/cert to t/certsconf/cert to t/certs
Signed-off-by: yiyiyimu <[email protected]>
Signed-off-by: yiyiyimu <[email protected]>
Signed-off-by: yiyiyimu <[email protected]>
Signed-off-by: yiyiyimu <[email protected]>
Signed-off-by: yiyiyimu <[email protected]>
Signed-off-by: yiyiyimu <[email protected]>
Signed-off-by: yiyiyimu <[email protected]>
Member
Author
|
Kind of stuck here and need some help. Thx~ |
juzhiyuan
reviewed
Nov 19, 2020
| # - "::/64" | ||
| # port_admin: 9180 # use a separate port | ||
| https_admin: true # enable HTTPS when use a separate port for Admin API. | ||
| # https_admin: true # enable HTTPS when use a separate port for Admin API. |
Member
|
It is another issue now. I think it is caused by ssl not being enabled by default: You can modify the test case accordingly and move on. |
Signed-off-by: yiyiyimu <[email protected]>
Member
Author
|
Thank you for the fix and problem pointing out @nic-chen! All test passed and ready to be reviewed~ |
Signed-off-by: yiyiyimu <[email protected]>
moonming
reviewed
Nov 19, 2020
| # ssl_trusted_certificate: /path/to/ca-cert # Specifies a file path with trusted CA certificates in the PEM format | ||
| # used to verify the certificate when APISIX needs to do SSL/TLS handshaking | ||
| # with external services (e.g. etcd) | ||
| ssl_cert: "" |
Member
There was a problem hiding this comment.
Here is the path or content of the certificate? we need to add comments.
Yiyiyimu
changed the title
conf/cert to t/certsconf/cert to t/certs and disable ssl by default
moonming
approved these changes
Nov 20, 2020
Member
|
@nic-chen please take a look |
nic-chen
approved these changes
Nov 20, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
fix #2110
Pre-submission checklist: