Skip to content

feature: health check supports custom host port.#1914

Merged
membphis merged 3 commits into
apache:masterfrom
shuaijinchao:feature/health/check/customized/port
Jul 28, 2020
Merged

feature: health check supports custom host port.#1914
membphis merged 3 commits into
apache:masterfrom
shuaijinchao:feature/health/check/customized/port

Conversation

@shuaijinchao

Copy link
Copy Markdown
Member

What this PR does / why we need it:

FIX #1811

Pre-submission checklist:

  • Did you explain what problem does this PR solve? Or what new features have been added?
  • Have you added corresponding test cases?
  • Have you modified the corresponding document?
  • Is this PR backward compatible?

@shuaijinchao
shuaijinchao requested a review from membphis July 27, 2020 16:55
@membphis

Copy link
Copy Markdown
Member

add test cases about invalid port, eg: port = -1 or port = 9999999

Comment thread apisix/schema_def.lua Outdated
@shuaijinchao

Copy link
Copy Markdown
Member Author

add test cases about invalid port, eg: port = -1 or port = 9999999

OK, no problem

@shuaijinchao

Copy link
Copy Markdown
Member Author

@membphis already fixed, please recheck.

@membphis
membphis merged commit 520ef31 into apache:master Jul 28, 2020
@membphis

Copy link
Copy Markdown
Member

@shuaijinchao merged, many thx

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

request help: Health Checks can support customized PORT ?

2 participants