Skip to content

makefile: add comments for install command.#1912

Merged
membphis merged 3 commits into
apache:masterfrom
membphis:makefile-install
Jul 29, 2020
Merged

makefile: add comments for install command.#1912
membphis merged 3 commits into
apache:masterfrom
membphis:makefile-install

Conversation

@membphis

@membphis membphis commented Jul 27, 2020

Copy link
Copy Markdown
Member

What this PR does / why we need it:

fix #1895.

Pre-submission checklist:

  • Did you explain what problem does this PR solve? Or what new features have been added?
  • Have you added corresponding test cases?
  • Have you modified the corresponding document?
  • Is this PR backward compatible?

@lilien1010 lilien1010 left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

good

@membphis
membphis merged commit 3947f06 into apache:master Jul 29, 2020
@membphis
membphis deleted the makefile-install branch July 29, 2020 11:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

bug: make install did not install lua deps to apisix install dir

3 participants