Skip to content

doc(k8s): removed unnecessary configurations.#1891

Merged
moonming merged 4 commits into
apache:masterfrom
gxthrj:kv/k8s-doc
Jul 31, 2020
Merged

doc(k8s): removed unnecessary configurations.#1891
moonming merged 4 commits into
apache:masterfrom
gxthrj:kv/k8s-doc

Conversation

@gxthrj

@gxthrj gxthrj commented Jul 23, 2020

Copy link
Copy Markdown
Contributor

What this PR does / why we need it:

1.make config.yaml from the latest version
2.remove some config not necessary

Pre-submission checklist:

  • Did you explain what problem does this PR solve? Or what new features have been added?
  • Have you added corresponding test cases?
  • Have you modified the corresponding document?
  • Is this PR backward compatible?

@moonming moonming changed the title style：modify kubernetes doc,make config.yaml from the latest version … doc(k8s): removed unnecessary configurations. Jul 23, 2020
juzhiyuan
juzhiyuan reviewed Jul 23, 2020
View reviewed changes
Comment thread kubernetes/README.md Outdated
Comment thread kubernetes/README.md Outdated
Comment thread kubernetes/README.md
Comment thread kubernetes/README.md Outdated
Comment thread kubernetes/config.sh Outdated
@gxthrj gxthrj mentioned this pull request Jul 27, 2020
Closed
@membphis

membphis commented Jul 28, 2020

Copy link
Copy Markdown
Member

@gxthrj please take a look at the output of Github Action:

https://github.com/apache/incubator-apisix/pull/1891/checks?check_run_id=913422137#step:6:61

Scan detected 2 error(s) in 2 file(s):
Reading configuration file [.travis/ASF-Release.cfg]...
Scanning files starting at [./]...
Scan detected 2 error(s) in 2 file(s):
  [./kubernetes/config.sh]:
       1: file does not include required license header.
  [./kubernetes/deployment.yaml]:
     113: file does not end with EOL.

@gxthrj

gxthrj commented Jul 29, 2020

Copy link
Copy Markdown
Contributor Author

@gxthrj please take a look at the output of Github Action:

https://github.com/apache/incubator-apisix/pull/1891/checks?check_run_id=913422137#step:6:61

Scan detected 2 error(s) in 2 file(s):
Reading configuration file [.travis/ASF-Release.cfg]...
Scanning files starting at [./]...
Scan detected 2 error(s) in 2 file(s):
  [./kubernetes/config.sh]:
       1: file does not include required license header.
  [./kubernetes/deployment.yaml]:
     113: file does not end with EOL.

done

@moonming
moonming merged commit f37a1dd into apache:master Jul 31, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@juzhiyuan juzhiyuan juzhiyuan approved these changes
@membphis membphis membphis approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@gxthrj @membphis @juzhiyuan @moonming