Skip to content

change: add more prometheus metrics(etcd modify index)#1888

Merged
nic-chen merged 18 commits into
apache:masterfrom
nic-chen:prometheus-more-metrics
Jul 30, 2020
Merged

change: add more prometheus metrics(etcd modify index)#1888
nic-chen merged 18 commits into
apache:masterfrom
nic-chen:prometheus-more-metrics

Conversation

@nic-chen

@nic-chen nic-chen commented Jul 23, 2020

Copy link
Copy Markdown
Member

What this PR does / why we need it:

add more prometheus metrics for better understanding the situation of APISIX nodes.

#1885

Pre-submission checklist:

  • Did you explain what problem does this PR solve? Or what new features have been added?
  • Have you added corresponding test cases?
  • Have you modified the corresponding document?
  • Is this PR backward compatible?

@nic-chen
nic-chen requested a review from membphis July 23, 2020 01:20
@nic-chen nic-chen changed the title change: add more prometheus metrics(hostname, etcd modify index) change: add more prometheus metrics(etcd modify index) Jul 23, 2020
Comment thread apisix/plugins/prometheus/exporter.lua
@membphis

Copy link
Copy Markdown
Member

Because we added some new metrics this time, it will affect the performance, so let’s do a simple performance test.

Comment thread apisix/plugins/prometheus/exporter.lua
Comment thread apisix/plugins/prometheus/exporter.lua
Comment thread apisix/plugins/prometheus/exporter.lua
@membphis

Copy link
Copy Markdown
Member

@nic-chen if you have fixed them, you can click this button, it means you have fixed it.

image

Comment thread apisix/core/config_etcd.lua Outdated
Comment thread apisix/core/config_etcd.lua Outdated
Comment thread apisix/core/config_etcd.lua
Comment thread apisix/core/config_etcd.lua Outdated
@membphis

Copy link
Copy Markdown
Member

@nic-chen please update the checklist, it seems that we are missing Have you modified the corresponding document? .

@nic-chen
nic-chen merged commit 7f64ba8 into apache:master Jul 30, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants