feat: Support admin API authentication with SSL certificates#1747
Merged
Conversation
membphis
requested changes
Jun 22, 2020
moonming
reviewed
Jun 22, 2020
membphis
reviewed
Jun 22, 2020
membphis
approved these changes
Jun 23, 2020
membphis
left a comment
membphis
left a comment
Member
There was a problem hiding this comment.
minor style point, we can merge it first
Member
|
@nic-chen the Travis-CI seems been blocked. you can rebase your branch. |
moonming
requested changes
Jun 24, 2020
moonming
changed the title
moonming
requested changes
Jun 24, 2020
moonming
requested changes
Jun 24, 2020
moonming
requested changes
Jun 24, 2020
membphis
reviewed
Jun 24, 2020
# Conflicts: # bin/apisix
membphis
reviewed
Jul 17, 2020
| services: | ||
| - docker | ||
| env: OSNAME=linux_openresty | ||
| - os: linux |
Member
There was a problem hiding this comment.
run this test case in Github Action, the Travis-CI is slow.
what do you think? @nic-chen
Member
Author
There was a problem hiding this comment.
It's good. I will try to move to github actions.
Member
|
@nic-chen please rebase your branch with master |
# Conflicts: # .travis.yml
Member
|
I think we can merge this PR first, and then submit the PR separately to fix it: #1747 (comment) |
moonming
approved these changes
Jul 21, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Support client-to-server authentication with SSL certificates for admin api.