fix(gcp): report auth_file path instead of file contents in parse error#13409
Merged
shreemaan-abhishek merged 4 commits intoMay 25, 2026
Merged
Conversation
dosubot
Bot
added
the
size:S
membphis
previously approved these changes
May 21, 2026
dosubot
Bot
added
size:M
nic-6443
approved these changes
May 22, 2026
AlinsRan
approved these changes
May 22, 2026
membphis
approved these changes
May 22, 2026
wistefan
pushed a commit
to wistefan/apisix
that referenced
this pull request
Jun 16, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
The GCP secret backend (
apisix/secret/gcp.lua) and thegoogle-cloud-loggingplugin both read a credentials file configured viaauth_file. When that file fails to parse as JSON, the error message embedded the entire raw file content.This change reports the configured
auth_filepath in the parse-failure message instead of the file content, making it consistent with the adjacent read-failure and schema-check error messages in the same functions. The underlying JSON decode error is still included.Which issue(s) this PR fixes:
N/A
Checklist