fix(ai-prompt-template): fix malformed JSON error message#13096
Merged
Baoyuantop merged 3 commits intoApr 16, 2026
Conversation
dosubot
Bot
added
size:XS
Contributor
|
Please update the code in all relevant places. |
Contributor
|
Hi @sihyeonn, following up on the previous review comments. Please let us know if you have any updates. Thank you. |
Contributor
Author
|
Hi, thanks for the follow-up. The fix has been applied — the error message now correctly reflects the malformed JSON case. Ready for review whenever you get a chance. |
Contributor
|
Hi @sihyeonn, I mean, there are several similar errors; could you fix them all at once? |
dosubot
Bot
added
size:S
The error message in get_request_body_table() had two issues: - Grammatical error: "could not get parse" instead of "could not parse" - The err variable was added as a separate table element instead of being concatenated to the message string, causing the error detail to be silently dropped. This aligns with the correct pattern used in ai-prompt-decorator.lua. Signed-off-by: Sihyeon Jang <[email protected]>
…ted places Apply the same error message fix to ai-prompt-decorator.lua and core/request.lua, which contained the same "could not get parse" typo as ai-prompt-template.lua. Signed-off-by: Sihyeon Jang <[email protected]>
Update expected response_body in ai-proxy.t and ai-proxy-multi.t to match the corrected error message "could not parse JSON request body" (removed erroneous "get" from "could not get parse"). Signed-off-by: Sihyeon Jang <[email protected]>
sihyeonn
force-pushed
the
fix/ai-prompt-template-error-msg
branch
from
April 9, 2026 23:08
c64875a to
f05ec83
Compare
nic-6443
approved these changes
Apr 15, 2026
Baoyuantop
approved these changes
Apr 15, 2026
shreemaan-abhishek
approved these changes
Apr 16, 2026
5 tasks
wistefan
pushed a commit
to wistefan/apisix
that referenced
this pull request
Jun 16, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
The error message in
get_request_body_table()had two issues:"could not get parse"instead of"could not parse"errwas added as a separate table element ({ message = "...: ", err }) instead of being concatenated to the message string ({ message = "...: " .. err }), causing the error detail to be silently dropped from the response.The correct pattern already exists in
ai-prompt-decorator.lua:76.Before
After