Skip to content

feat(standalone): reject configurations when configured with unknown plugin#13046

Merged
shreemaan-abhishek merged 9 commits into
apache:masterfrom
shreemaan-abhishek:disallow-routes-with-unknown-plugin-in-stdalone-mode
Mar 2, 2026
Merged

feat(standalone): reject configurations when configured with unknown plugin#13046
shreemaan-abhishek merged 9 commits into
apache:masterfrom
shreemaan-abhishek:disallow-routes-with-unknown-plugin-in-stdalone-mode

Conversation

@shreemaan-abhishek

Copy link
Copy Markdown
Contributor

Description

Which issue(s) this PR fixes:

Fixes #12189

Checklist

  • I have explained the need for this PR and the problem it solves
  • I have explained the changes or the new features added to this PR
  • I have added tests corresponding to this change
  • I have updated the documentation to reflect this change
  • I have verified that this change is backward compatible (If not, please discuss on the APISIX mailing list first)

@dosubot dosubot Bot added size:L This PR changes 100-499 lines, ignoring generated files. enhancement New feature or request plugin labels Feb 27, 2026
Signed-off-by: Abhishek Choudhary <[email protected]>
membphis
membphis previously approved these changes Feb 27, 2026

@membphis membphis left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, only one minor issue

Comment thread apisix/plugin.lua Outdated
function _M.plugin_checker(item, schema_type)
if item.plugins then
local ok, err = check_schema(item.plugins, schema_type, true)
local skip_disabled = core.config.type ~= "yaml"

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

another name: skip_disabled_plugins

@Baoyuantop

Copy link
Copy Markdown
Contributor

Standalone mode supports two config_providers: yaml and json. The PR only checks "yaml"; routes in Standalone mode will still skip unknown plugin checks.

Signed-off-by: Abhishek Choudhary <[email protected]>
f
Signed-off-by: Abhishek Choudhary <[email protected]>
f
Signed-off-by: Abhishek Choudhary <[email protected]>
f
Signed-off-by: Abhishek Choudhary <[email protected]>
This reverts commit 4a1f405.
f
Signed-off-by: Abhishek Choudhary <[email protected]>
Signed-off-by: Abhishek Choudhary <[email protected]>
@shreemaan-abhishek
shreemaan-abhishek merged commit 16b9d7e into apache:master Mar 2, 2026
20 of 21 checks passed
@cruftex

cruftex commented Mar 2, 2026

Copy link
Copy Markdown

@shreemaan-abhishek Thanks! Great!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request plugin size:L This PR changes 100-499 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

bug: Apisix should reject configurations with missing plugins in standalone mode

5 participants