feat(limit-count): support configuring multiple rules#12977
Merged
shreemaan-abhishek merged 8 commits intoFeb 10, 2026
Conversation
Signed-off-by: Abhishek Choudhary <[email protected]>
Signed-off-by: Abhishek Choudhary <[email protected]>
dosubot
Bot
added
size:XL
Signed-off-by: Abhishek Choudhary <[email protected]>
kayx23
reviewed
Feb 5, 2026
| | time_window | integer | True | | > 0 | The time interval corresponding to the rate limiting `count` in seconds. | | ||
| | count | integer | False | | > 0 | The maximum number of requests allowed within a given time interval. Required if `rules` is not configured. | | ||
| | time_window | integer | False | | > 0 | The time interval corresponding to the rate limiting `count` in seconds. Required if `rules` is not configured. | | ||
| | rules | array[object] | False | | | A list of rate limiting rules. Each rule is an object containing `count`, `time_window`, and `key`. | |
Member
There was a problem hiding this comment.
Need to add rows for rules.count, rules.time_winddow, and rules.key.
Signed-off-by: Abhishek Choudhary <[email protected]>
Signed-off-by: Abhishek Choudhary <[email protected]>
Signed-off-by: Abhishek Choudhary <[email protected]>
membphis
previously approved these changes
Feb 6, 2026
|
|
||
| core.log.info("limit count: ", count, ", time_window: ", time_window) | ||
| local function create_limit_obj(conf, rule, plugin_name) | ||
| core.log.info("create new " .. plugin_name .. " plugin instance", |
Member
There was a problem hiding this comment.
Suggested change
| core.log.info("create new " .. plugin_name .. " plugin instance", | |
| core.log.info("create new ", plugin_name, " plugin instance", |
Signed-off-by: Abhishek Choudhary <[email protected]>
Signed-off-by: Abhishek Choudhary <[email protected]>
membphis
approved these changes
Feb 9, 2026
nic-6443
approved these changes
Feb 10, 2026
wistefan
pushed a commit
to wistefan/apisix
that referenced
this pull request
Jun 16, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
After adding the support for usage of variables in rate limiting configuration via #12967, we can further take advantage of this dynamic construction of rate limiting rule by allowing to configure multiple rate limiting rules to implement intricate rate limiting strategies.
Checklist