fix(limit-count): use meta parent to identify plugin source#12900
Merged
nic-6443 merged 7 commits intoJan 15, 2026
Merged
Conversation
Signed-off-by: Abhishek Choudhary <[email protected]>
Signed-off-by: Abhishek Choudhary <[email protected]>
Signed-off-by: Abhishek Choudhary <[email protected]>
Signed-off-by: Abhishek Choudhary <[email protected]>
shreemaan-abhishek
marked this pull request as ready for review
January 14, 2026 08:02
dosubot
Bot
added
size:XL
shreemaan-abhishek
requested review from
bzp2010 and
membphis
and removed request for
membphis
January 14, 2026 08:03
membphis
reviewed
Jan 14, 2026
| end | ||
|
|
||
| local match, err = ngx.re.match(parent.resource_key, [[/apisix/([^/]+)/([^/]+)]]) | ||
|
|
| local match, err = ngx.re.match(parent.resource_key, [[/apisix/([^/]+)/([^/]+)]]) | ||
|
|
||
| if not match then | ||
| core.log.error("failed to generate key invalid parent resource key, err: ", err) |
Member
There was a problem hiding this comment.
I think we can remove the etcd_prefix, then it should be enough
we can always use it directly, eg: routes/r1
etcd:
host:
- "http://127.0.0.1:2379" # Replace with your etcd cluster host(s)
prefix: "/apisix" # The default prefix, modify as needed
timeout: 30
nic-6443
reviewed
Jan 14, 2026
Signed-off-by: Abhishek Choudhary <[email protected]>
membphis
previously approved these changes
Jan 14, 2026
nic-6443
previously approved these changes
Jan 14, 2026
Signed-off-by: Abhishek Choudhary <[email protected]>
Signed-off-by: Abhishek Choudhary <[email protected]>
shreemaan-abhishek
dismissed stale reviews from nic-6443 and membphis
via
January 14, 2026 09:37
5caff96
nic-6443
approved these changes
Jan 14, 2026
membphis
approved these changes
Jan 14, 2026
AlinsRan
approved these changes
Jan 15, 2026
wistefan
pushed a commit
to wistefan/apisix
that referenced
this pull request
Jun 16, 2026
…2900) Signed-off-by: Abhishek Choudhary <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
When configuring rate limiting plugin in different consumers, quota usage for one consumer would affect another consumer's quota too. This happened because the rate limiting key being constructed would be unaware of the source of the rate limiting plugin hence the rate limiting key for different consumer would produce same key for a given route.
To fix this we ensure that parent information is filled in to plugin configurations for plugins configured in a consumer.
Which issue(s) this PR fixes:
Fixes #12896
Checklist