Skip to content

feat: rate limiting plugins support setting keepalive for redis policy#12861

Merged
Baoyuantop merged 12 commits into
apache:masterfrom
ChuanFF:rate-limit-plugin-redis-keepalive
Jan 28, 2026
Merged

feat: rate limiting plugins support setting keepalive for redis policy#12861
Baoyuantop merged 12 commits into
apache:masterfrom
ChuanFF:rate-limit-plugin-redis-keepalive

Conversation

@ChuanFF

@ChuanFF ChuanFF commented Jan 5, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor

Description

  1. support redis connection keepalive setting for limit-count,limit-conn,limit-req.
  2. fix some test case err(t/plugin/limit-count-redis4.t，Test2)
  3. in redis-cluster policy, the current redis_timeout only applies to send_timeout. This pr will make the values ​​of connect_timeout and send_timeout consistent with redis_timeout.

Which issue(s) this PR fixes:

relate issue: #12817

Checklist

  • I have explained the need for this PR and the problem it solves
  • I have explained the changes or the new features added to this PR
  • I have added tests corresponding to this change
  • I have updated the documentation to reflect this change
  • I have verified that this change is backward compatible (If not, please discuss on the APISIX mailing list first)

@dosubot dosubot Bot added size:L This PR changes 100-499 lines, ignoring generated files. enhancement New feature or request labels Jan 5, 2026
Baoyuantop
Baoyuantop reviewed Jan 7, 2026
View reviewed changes
Comment thread apisix/plugins/limit-conn/limit-conn-redis.lua Outdated
Comment thread apisix/utils/rediscluster.lua Outdated
Comment thread apisix/utils/rediscluster.lua Outdated
Comment thread t/plugin/limit-conn-redis.t Outdated
Comment thread docs/zh/latest/plugins/limit-conn.md
@Baoyuantop Baoyuantop added the wait for update wait for the author's response in this issue/PR label Jan 7, 2026
@john1337

john1337 commented Jan 14, 2026

Copy link
Copy Markdown

when will this merge be released,cause if not using the redis connection pool,limit-count plugin can't limit qps more than 8000,it will throw phase_func(): failed to limit count: timeout

@Baoyuantop Baoyuantop added awaiting review and removed wait for update wait for the author's response in this issue/PR labels Jan 20, 2026
nic-6443
nic-6443 reviewed Jan 26, 2026
View reviewed changes
Comment thread t/plugin/limit-count-redis-cluster3.t Outdated
nic-6443
nic-6443 reviewed Jan 26, 2026
View reviewed changes
Comment thread t/plugin/limit-conn-redis.t Outdated
nic-6443
nic-6443 reviewed Jan 26, 2026
View reviewed changes
Comment thread t/plugin/limit-req-redis.t Outdated
AlinsRan
AlinsRan previously approved these changes Jan 26, 2026
View reviewed changes
@Baoyuantop Baoyuantop added wait for update wait for the author's response in this issue/PR and removed awaiting review labels Jan 26, 2026
@ChuanFF

ChuanFF commented Jan 26, 2026

Copy link
Copy Markdown
Contributor Author

The code changes have been completed; please help review the code again.

nic-6443
nic-6443 previously approved these changes Jan 27, 2026
View reviewed changes
membphis
membphis previously approved these changes Jan 27, 2026
View reviewed changes
nic-chen
nic-chen previously approved these changes Jan 27, 2026
View reviewed changes
@ChuanFF
ChuanFF dismissed stale reviews from nic-chen, membphis, and nic-6443 via 7fb6da6 January 27, 2026 13:55
@Baoyuantop
Baoyuantop merged commit 630891b into apache:master Jan 28, 2026
22 checks passed
@kayx23 kayx23 mentioned this pull request Jan 30, 2026
Closed
@Baoyuantop Baoyuantop mentioned this pull request Mar 4, 2026
Closed
@membphis membphis mentioned this pull request May 12, 2026
Open
wistefan pushed a commit to wistefan/apisix that referenced this pull request Jun 16, 2026
@ChuanFF @wistefan
feat: rate limiting plugins support setting keepalive for redis policy (
8be0f92 
apache#12861)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@nic-6443 nic-6443 nic-6443 approved these changes
@Baoyuantop Baoyuantop Baoyuantop approved these changes
@nic-chen nic-chen nic-chen approved these changes
@membphis membphis membphis left review comments
@AlinsRan AlinsRan AlinsRan left review comments

Assignees

No one assigned

Labels

enhancement New feature or request size:L This PR changes 100-499 lines, ignoring generated files. user responded wait for update wait for the author's response in this issue/PR

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

7 participants

@ChuanFF @john1337 @membphis @nic-6443 @Baoyuantop @nic-chen @AlinsRan