fix(skywalking): start timer when route is hit#12855
Merged
moonming merged 3 commits intoJan 23, 2026
Merged
Conversation
Signed-off-by: Abhishek Choudhary <[email protected]>
shreemaan-abhishek
changed the title
Signed-off-by: Abhishek Choudhary <[email protected]>
shreemaan-abhishek
marked this pull request as ready for review
January 2, 2026 04:27
dosubot
Bot
added
size:L
shreemaan-abhishek
requested review from
AlinsRan,
Baoyuantop,
bzp2010,
membphis,
moonming and
nic-6443
January 6, 2026 10:48
nic-6443
approved these changes
Jan 21, 2026
membphis
approved these changes
Jan 23, 2026
AlinsRan
approved these changes
Jan 23, 2026
wistefan
pushed a commit
to wistefan/apisix
that referenced
this pull request
Jun 16, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
When skywalking is enabled but
plugin_attris not configured, the default skywalkingendpoint_addris taken into affect and error logs may be continuously printed as that endpoing may not be available by default. This behaviour is annoying and unnecessary.So this PR introduces a change that starts the timer that performs reporting only after a route configuring
skywalkingplugin is hit instead of starting it directly when the plugin is initialised during startup.Checklist