fix: Make protocol_name optional and default to 'MQTT' for mqtt plugin#12831
Merged
Baoyuantop merged 7 commits intoDec 26, 2025
Merged
Conversation
The mqtt protocol_name default to 'MQTT' as it is the standard protocol. And the protocol_name is now optional as it is not strictly required, reducing user configuration overhead.
dosubot
Bot
added
size:M
YapWC
changed the title
Baoyuantop
previously approved these changes
Dec 23, 2025
Contributor
|
Hi @YapWC, please fix the failed lint CI |
Baoyuantop
added
the
wait for update
Contributor
Author
It is fixed ya. |
Baoyuantop
added
awaiting review
and removed
wait for update
Baoyuantop
previously approved these changes
Dec 24, 2025
Baoyuantop
requested review from
AlinsRan,
bzp2010,
kayx23,
membphis,
moonming,
nic-6443 and
shreemaan-abhishek
December 24, 2025 08:22
ronething
previously approved these changes
Dec 25, 2025
nic-6443
reviewed
Dec 25, 2025
Contributor
|
Hi @YapWC, following up on the previous review comments. Please let us know if you have any updates. Thank you. |
Baoyuantop
added
wait for update
Contributor
Author
|
Hi @Baoyuantop here is the latest fixes, feel free to let me know if there is any else. |
Baoyuantop
previously approved these changes
Dec 25, 2025
Contributor
|
Hi @YapWC, please fix lint error |
Contributor
Author
|
Okay I think it is fixed this time. |
Baoyuantop
approved these changes
Dec 25, 2025
Baoyuantop
added
awaiting review
and removed
wait for update
ronething
approved these changes
Dec 26, 2025
nic-6443
approved these changes
Dec 26, 2025
wistefan
pushed a commit
to wistefan/apisix
that referenced
this pull request
Jun 16, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
The mqtt protocol_name default to 'MQTT' as it is the standard protocol. And the protocol_name is now optional as it is not strictly required, reducing user configuration overhead.
Changes:
Which issue(s) this PR fixes:
Fixes #11589
Checklist