fix(performance): move the ipv6 check to schema validation#12714
Merged
Conversation
nic-6443
reviewed
Oct 30, 2025
nic-6443
reviewed
Oct 30, 2025
membphis
reviewed
Oct 30, 2025
membphis
left a comment
Member
There was a problem hiding this comment.
more test cases:
call Admin API, to confirm the schema check is working right
Contributor
Author
done |
membphis
previously approved these changes
Oct 30, 2025
nic-6443
reviewed
Oct 30, 2025
nic-6443
previously approved these changes
Oct 30, 2025
nic-6443
approved these changes
Oct 31, 2025
membphis
approved these changes
Oct 31, 2025
nic-chen
approved these changes
Nov 4, 2025
shreemaan-abhishek
pushed a commit
to shreemaan-abhishek/apisix
that referenced
this pull request
Jan 2, 2026
) (apache#1068) Signed-off-by: Nic <[email protected]> Co-authored-by: Ashish Tiwari <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.


There is a big performance difference between APISIX 3.10 and 2.13 when no plug-ins are enabled.
After comparing the flame graphs of APISIX 3.10 and 2.13 versions, it can be clearly seen that the biggest difference is in the pick_server function. After comparing the function codes of the two versions, it is found that the code of version 3.10 has added logic to traverse all upstream nodes, and when there are more upstream nodes during performance testing, so the difference is more obvious.
After backtracking the changes, it was found that the changes traversing all upstream nodes were introduced by this pr #7594.
change point
apisix/apisix/balancer.lua
Lines 198 to 202 in 73618d4
check_schemafunction to implement this logicNote: This change is backwards compatible. When detecting data from etcd, it modifies the host for compatibility