fix(plugin_metadata): ensure enable_data_encryption initialization & querying issue#12624
Merged
Conversation
dosubot
Bot
added
size:L
laz-xyr
changed the title
laz-xyr
changed the title
Contributor
Author
|
@Baoyuantop fix ci error,when merging the upstream, due to this pr #12603, no longer populates default values when writing, rename node.name to id to avoid decryption failure |
laz-xyr
commented
Sep 22, 2025
Contributor
Author
|
@Baoyuantop CI Tars Need I fix it? |
Contributor
This seems unrelated to this PR. I'll start reviewing this PR when I have free time. |
Baoyuantop
self-requested a review
September 25, 2025 08:38
Baoyuantop
approved these changes
Sep 26, 2025
Baoyuantop
requested review from
AlinsRan,
Revolyssup,
nic-6443 and
nic-chen
September 26, 2025 02:56
AlinsRan
approved these changes
Sep 29, 2025
membphis
approved these changes
Oct 28, 2025
Baoyuantop
changed the title
Contributor
|
Hi @Crazy-xyr, there is still a failed CI, we can merge the main branch code and try again. |
Contributor
Author
|
@Baoyuantop My local repository ci checks all pass, but pr always has some tests failing. Can you retry only the failed tests |
github-project-automation
Bot
moved this from 👀 In review
to ✅ Done
in ⚡️ Apache APISIX Roadmap
5 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
plugin.enable_data_encryption does not initialization when no plugin configuration for routes, plugin_metadata, etc，When not initialized, querying non-existent plugin_metadata via the admin_api will report http 500
Just like encrypt_conf and decrypt_conf, Instead of directly accessing plugin.enable_data_encryption, call the method enable_gde()，decrypt_params metadata is changed to the same code style as node and list to avoid nil
Which issue(s) this PR fixes:
Fixes #12618
Checklist