fix: healthcheck manager missing runtime information#12607
Merged
Revolyssup merged 32 commits intoSep 16, 2025
Merged
Conversation
Revolyssup
marked this pull request as draft
September 10, 2025 10:16
dosubot
Bot
added
size:L
Revolyssup
marked this pull request as ready for review
September 10, 2025 18:17
Revolyssup
requested review from
bzp2010,
membphis and
nic-6443
and removed request for
bzp2010 and
membphis
September 11, 2025 12:19
dosubot
Bot
added
size:XL
membphis
reviewed
Sep 15, 2025
| config = config, | ||
| config_util = require("apisix.core.config_util"), | ||
| sleep = utils.sleep, | ||
| fetch_latest_conf = fetch_latest_conf, |
Member
There was a problem hiding this comment.
in my opinion:
create a new module, it's name can be resource
then we can use it by call core.resource.get_nodes_ver, what do you think? @Revolyssup
membphis
reviewed
Sep 15, 2025
| return size | ||
| end | ||
|
|
||
| function _M.upstream_version(index, nodes_ver) |
Member
There was a problem hiding this comment.
move this function to upstream lua module
Contributor
Author
There was a problem hiding this comment.
done. moved to utils/upstream
nic-6443
approved these changes
Sep 16, 2025
AlinsRan
approved these changes
Sep 16, 2025
jizhuozhi
pushed a commit
to jizhuozhi/apisix
that referenced
this pull request
Oct 18, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Solution:
Checklist